Michael Kublin has posted comments on this change.

Change subject: core : Start to remove internal drive mapping
......................................................................


Patch Set 2:

Maor, maybe u will think a little, and u will discover a following: 
1. attach/detach scenario is not working (it means a floating feature) now 
because of way of calculation disk alias that u inserted, maybe we will ask a 
PM if they need a floating scenario.

2. I know at least 5 cases when we are creating a disk with duplicate alias 
today, how the internal drive mapping is related to alias, may be u will change 
a formula and will calculate an alias in a different way which is not related 
to internal drive mapping and will not screw up floating disk scenario?

Or u need to ask someone else?

--
To view, visit http://gerrit.ovirt.org/4358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I020b25f04820b6cbef60764ae8169050bcbdc5bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to