Maor Lipchuk has posted comments on this change.

Change subject: core : Start to remove internal drive mapping
......................................................................


Patch Set 2:

getCorrectDriveForDisk in VMHandler should not be deleted.
Instead getting the number of the disk from the internal drive mapping it can 
be get from the disk alias name (probably regex should be used).

In this patch the suggestion alias name will give duplicate name which is not a 
valid behaviour.

--
To view, visit http://gerrit.ovirt.org/4358
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I020b25f04820b6cbef60764ae8169050bcbdc5bc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to