Ori Liel has posted comments on this change.
Change subject: restapi: Add support for removing a Template from specified
storage domain(s)
......................................................................
Patch Set 2: (3 inline comments)
some comments inside
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDisksResource.java
Line 38: public Response remove(@PathParam("id") String id);
Not crazy about the fact that this interface extends *ReadOnly*DevicesResource,
but adds remove().... maybe rename:
ReadOnlyDevicesResource-->ViewableDevicesResource and
ReadOnlyDeviceResource-->ViewableDeviceResource? Interfaces are supposed to add
abilities, not prevent abilities.
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 1741: optionalArguments: {action.storage_domain.id: 'xs:string'}
Since user is allowd to pass both storage-domain id and 'force', please make
this into one signature with two optional arguments.
mandatoryArguments: {}
optionalArguments: {action.storage_domain.id: 'xs:string', action.force:
'xs:boolean'}
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java
Line 9: import org.ovirt.engine.core.common.action.AddUserParameters;
part of this patch?
--
To view, visit http://gerrit.ovirt.org/4566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4d57d183671f89aea632ef5bb15db5a8fb921f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
