Ori Liel has posted comments on this change.
Change subject: restapi: Add support for removing a Template from specified
storage domain(s)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDisksResource.java
Line 38: public Response remove(@PathParam("id") String id);
You're not supposed to be able to delete something which is read-only.
This resource exposes list(), which enables viewing it's entities, so it's
'viewable'. If we want it to be edit, we make it implement 'editable'.
But making it implement an interface called ReadOnlyDeviceResource is an
attempt to use the interface mechanism to prevent abilities, and that's not how
interfaces are designed, they are used to incrementally add abilities.
So I believe ReadOnlyDeviceResource is simply a broken name. But this is not a
-1 for me, so it's your call.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java
Line 9: import org.ovirt.engine.core.common.action.AddUserParameters;
I believe if you 'git checkout' this file the project will compile. This unused
import doesn't bother git unless it thinks you touched this file. But this is
not a -1 either, so you can't get rid of this, you can still push it as far as
I'm concerned.
--
To view, visit http://gerrit.ovirt.org/4566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4d57d183671f89aea632ef5bb15db5a8fb921f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
