Michael Pasternak has posted comments on this change.
Change subject: restapi: Add support for removing a Template from specified
storage domain(s)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDisksResource.java
Line 38: public Response remove(@PathParam("id") String id);
Ori,
they both DevicesResource/ReadOnlyDevicesResource provide list() sig., so both
are Viewables, the difference is only in add/list/remove/etc signatures
DevicesResource adds, therefore i think ReadOnlyDeviceResource is better
naming convention in this context as its clearly differentiate between
ReadOnlyDeviceResource & DeviceResource
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGroupsResource.java
Line 9: import org.ovirt.engine.core.common.action.AddUserParameters;
git no, but mvn yes ...
--
To view, visit http://gerrit.ovirt.org/4566
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a4d57d183671f89aea632ef5bb15db5a8fb921f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
