Michael Kublin has posted comments on this change.
Change subject: core:Use shareable disk only for 3.1 DC version
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
Line 40: }
wrong logic a poolId should be retrieved from domain of disk and not passed by
params, also a provided vm can be at wrong pool
Line 107: protected boolean isVersionSupportedForShareable() {
How pool can be null? Only magic....
--
To view, visit http://gerrit.ovirt.org/4487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1928ea17b457b8a810b24637862d3977b7e001c8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
