Michael Kublin has posted comments on this change. Change subject: core:Use shareable disk only for 3.1 DC version ......................................................................
Patch Set 12: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java Line 42: } I don't like an idea to put that query at constarctor, first of all all AddDiskCommand will do an unneeded query, second we don't need a poolId for DetachDiskFromVmCommand and for UpdateVmDiskCommand, HotPlug and UnPlug, so putting at constractor is wrong -- To view, visit http://gerrit.ovirt.org/4487 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1928ea17b457b8a810b24637862d3977b7e001c8 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
