Michael Kublin has posted comments on this change.
Change subject: core:Use shareable disk only for 3.1 DC version
......................................................................
Patch Set 13: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
Line 56: for (VM vm : listVms) {
I don't know where u inserted , a lock code, same file at couple of patches
wtf...,
code should be like that:
buildSharedLockMap();
retValue = acquireLockInternal();
for(vm : listVms) {
if (vm.getstatus() != VMStatus.Down) {
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL);
}
}
}
--
To view, visit http://gerrit.ovirt.org/4487
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1928ea17b457b8a810b24637862d3977b7e001c8
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
