Alon Bar-Lev has posted comments on this change.
Change subject: core: Remove error message when reports.xml doesn't exist
......................................................................
Patch Set 4: Code-Review-1
no need for complex mechanism.
each caller knows if the file is important or not.
just change the signature of keep backward compatibility signature:
ServletUtils:: public static void sendFile(final HttpServletRequest request,
final HttpServletResponse response, final File file, final String defaultType,
boolean cache) throws IOException {
to have new boolean parameter - show error.
this will be sufficient.
--
To view, visit http://gerrit.ovirt.org/25324
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf6b075eb4754c5bb4153da8c6032a01bf801516
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
