Liran Zelkha has posted comments on this change. Change subject: core: Remove error message when reports.xml doesn't exist ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/25324/4/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: > I can see the SP definition , but shouldn't it be called from engine when w We go with another solution Line 1: -------------------------------------------------- Line 2: -- DB helper functions Line 3: -------------------------------------------------- Line 4: Line 554: RETURN; Line 555: END; $procedure$ Line 556: LANGUAGE plpgsql; Line 557: Line 558: -- Remove a value from a CSV string in vdc_options > Please remove TWS Done Line 559: Create or replace FUNCTION fn_vdc_remove_spv_value(v_option_name varchar, v_value varchar) Line 560: returns void Line 561: AS $procedure$ Line 562: BEGIN Line 563: UPDATE vdc_options SET option_value=replace(option_value,v_value || ',','') WHERE option_name=v_option_name; Line 564: UPDATE vdc_options SET option_value=replace(option_value,',' || v_value,'') WHERE option_name=v_option_name; Line 565: UPDATE vdc_options SET option_value='' WHERE option_value=v_value AND option_name=v_option_name; Line 566: END; $procedure$ Line 567: LANGUAGE plpgsql; > The following function is more general it uses also the version provided an I replace my procedure - but I think it's nuts - this procedure is much harder to read than the 3 updates, and I'm not sure it's faster. -- To view, visit http://gerrit.ovirt.org/25324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf6b075eb4754c5bb4153da8c6032a01bf801516 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
