Simone Tiraboschi has posted comments on this change. Change subject: packaging: engine-backup: support dwh and reports ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/25850/1/packaging/bin/engine-backup.sh File packaging/bin/engine-backup.sh: Line 144: --reports-db-password=pass set reports database password Line 145: --reports-db-password set reports database password - interactively Line 146: --reports-db-name=name set reports database name Line 147: --reports-db-secured set a secured connection for reports Line 148: --reports-db-secured-validation validate host for reports > I think it will be much easier for people to use 3 different scripts in thi But probably you still want also to be able to backup all the of products via a single script using just a command so, in my opinion, this is not a bad choice. Line 149: Line 150: ENVIRONMENT VARIABLES Line 151: Line 152: OVIRT_ENGINE_DATABASE_PASSWORD Line 261: --db-user=*) Line 262: MY_DB_USER="${v}" Line 263: ;; Line 264: --db-passfile=*) Line 265: DB_PASSFILE="${v}" Isn't better to call it MY_DB_PASSFILE just for homogeneity? Line 266: [ -r "${DB_PASSFILE}" ] || \ Line 267: die "Can not read password file ${DB_PASSFILE}" Line 268: read -r MY_DB_PASSWORD < "${DB_PASSFILE}" Line 269: ;; Line 294: --dwh-db-user=*) Line 295: MY_DWH_DB_USER="${v}" Line 296: ;; Line 297: --dwh-db-passfile=*) Line 298: DB_PASSFILE="${v}" Isn't better to call it MY_DWH_DB_PASSFILE just for homogeneity? Line 299: [ -r "${DB_PASSFILE}" ] || \ Line 300: die "Can not read password file ${DB_PASSFILE}" Line 301: read -r MY_DWH_DB_PASSWORD < "${DB_PASSFILE}" Line 302: ;; Line 327: --reports-db-user=*) Line 328: MY_REPORTS_DB_USER="${v}" Line 329: ;; Line 330: --reports-db-passfile=*) Line 331: DB_PASSFILE="${v}" Also here Line 332: [ -r "${DB_PASSFILE}" ] || \ Line 333: die "Can not read password file ${DB_PASSFILE}" Line 334: read -r MY_REPORTS_DB_PASSWORD < "${DB_PASSFILE}" Line 335: ;; -- To view, visit http://gerrit.ovirt.org/25850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
