Sandro Bonazzola has posted comments on this change. Change subject: packaging: engine-backup: support dwh and reports ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25850/1/packaging/bin/engine-backup.sh File packaging/bin/engine-backup.sh: Line 144: --reports-db-password=pass set reports database password Line 145: --reports-db-password set reports database password - interactively Line 146: --reports-db-name=name set reports database name Line 147: --reports-db-secured set a secured connection for reports Line 148: --reports-db-secured-validation validate host for reports > there is no problem to use all scripts. Before this become a war between keeping monolithic or split in multiple script, we're going to go GA on Monday: if we want this feature in I think we can accept it as is. Otherwise we can postpone this to 3.4.1 or even 3.5.0 since it's not a regression from 3.3.z and in this case we can drop this and go with the otopi / python implementation. Line 149: Line 150: ENVIRONMENT VARIABLES Line 151: Line 152: OVIRT_ENGINE_DATABASE_PASSWORD -- To view, visit http://gerrit.ovirt.org/25850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
