Alon Bar-Lev has posted comments on this change. Change subject: packaging: engine-backup: support dwh and reports ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/25850/1/packaging/bin/engine-backup.sh File packaging/bin/engine-backup.sh: Line 28: # Load jasper reports db credentials Line 29: get_jasper_db_cred() { Line 30: local key="$1" Line 31: Line 32: python -c " > Already talked with Sandro about that, he said we currently do not support we do support python3 in gentoo. we replace the used python in script to python2, but we cannot replace the above. please make it work in python3, it is trivial, less time than you talk to sandro, you write comment, I respond, etc... Line 33: import ConfigParser Line 34: import io Line 35: import os Line 36: Line 66: Line 67: # Globals Line 68: BACKUP_PATHS="/etc/ovirt-engine Line 69: /etc/ovirt-engine-dwh Line 70: /etc/ovirt-engine-reports > We'll make this clean and nice when we rewrite in python... this is no reason to present such solution. it takes the same resources to do this one or the other. why not invest the resources in the other? Line 71: /etc/pki/ovirt-engine Line 72: /etc/ovirt-engine-setup.conf.d Line 73: /var/lib/ovirt-engine-reports/build-conf Line 74: /etc/httpd/conf.d/ovirt-engine-root-redirect.conf Line 144: --reports-db-password=pass set reports database password Line 145: --reports-db-password set reports database password - interactively Line 146: --reports-db-name=name set reports database name Line 147: --reports-db-secured set a secured connection for reports Line 148: --reports-db-secured-validation validate host for reports > But probably you still want also to be able to backup all the of products v there is no problem to use all scripts. this script is way too complex, too much variables less reuse. having multiple script will enable you to use the same command-line argument for all scripts, making it much easier to use and read than these duplications throughout this code. Line 149: Line 150: ENVIRONMENT VARIABLES Line 151: Line 152: OVIRT_ENGINE_DATABASE_PASSWORD -- To view, visit http://gerrit.ovirt.org/25850 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
