Lior Vernia has posted comments on this change. Change subject: core: Rename all management networks and profiles ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25931/1/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 1281: BEGIN Line 1282: select option_value into v_old_name from vdc_options where option_name = 'ManagementNetwork' and version = 'general'; Line 1283: perform fn_db_update_config_value('ManagementNetwork', v_name, 'general'); Line 1284: update network set name = v_name where name = v_old_name; Line 1285: update vnic_profiles set name = v_name where name = v_old_name; > Could you verify when this stored procedure is being invoked ? Supposed to be invoked also on upgrade. Currently (= before the current patch) the rename would be invoked without checking host/VM usage. I think that it in fact should be invoked in those cases, but also update the proper related entities. Which entities reference network/profile by name rather than by ID? I know hosts do, but there's nothing to be done about that at the moment (or is there?). VMs and templates reference profiles by ID, so I don't think there are issues there. Currently running VMs should still be alright, as long as hosts are out of sync (due to their configuration not being updated in upgrade). There would have to be a step of shutting down VMs and synchronizing host networking though for everything to move to "rhevm", shouldn't there? I think it's inevitable if we insist on moving from "ovirtmgmt" to "rhevm"... Line 1286: END; $procedure$ Line 1287: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/25931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59e6278f283cafdc2f865e18129349f5905f6d3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
