Moti Asayag has posted comments on this change. Change subject: core: Rename all management networks and profiles ......................................................................
Patch Set 1: (1 comment) Alon, Is there an option to execute this stored procedure as part of the new installation and not as part of any upgrade ? http://gerrit.ovirt.org/#/c/25931/1/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 1281: BEGIN Line 1282: select option_value into v_old_name from vdc_options where option_name = 'ManagementNetwork' and version = 'general'; Line 1283: perform fn_db_update_config_value('ManagementNetwork', v_name, 'general'); Line 1284: update network set name = v_name where name = v_old_name; Line 1285: update vnic_profiles set name = v_name where name = v_old_name; > Supposed to be invoked also on upgrade. Currently (= before the current pat Suppose a user creates a network named 'ovirtmgmt' in his RHEVM setup... This might end with 2 rhevm networks in the same DC. So there is a need to verify there is only single network named 'ovirtmgmt' if no 'rhevm' network is presented (per data-center). Or just add to release notes a limitation not to use 'ovirtmgmt' as a network name in RHEVM. I think that this stored procedure should be effective only on new installation, since on existing setup, any created DC within the engine will be created with the proper management network and default vnic profile name. So the only issue is with the Default DC, assuming network wasn't used (which it shouldn't be since this is a new installation); So perhaps there is an option to verify the upgrade is run only in new installation and not as part of upgrade ? Line 1286: END; $procedure$ Line 1287: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/25931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59e6278f283cafdc2f865e18129349f5905f6d3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
