Lior Vernia has posted comments on this change. Change subject: core: Rename all management networks and profiles ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25931/1/packaging/dbscripts/network_sp.sql File packaging/dbscripts/network_sp.sql: Line 1281: BEGIN Line 1282: select option_value into v_old_name from vdc_options where option_name = 'ManagementNetwork' and version = 'general'; Line 1283: perform fn_db_update_config_value('ManagementNetwork', v_name, 'general'); Line 1284: update network set name = v_name where name = v_old_name; Line 1285: update vnic_profiles set name = v_name where name = v_old_name; > Suppose a user creates a network named 'ovirtmgmt' in his RHEVM setup... Moti, I think what you described in the first paragraph can't happen. The management network name is retrieved from the DB in this very procedure; if this were a RHEV setup, then that name would be "rhevm" and no renaming would be done. And this would be the same in all DCs, as in all of them the management network is always created with the same name and can't be removed, etc. However, a user may create a network called "rhevm" in an oVirt setup, which would pose a problem if it is changed to RHEV. I agree that this probably shouldn't be run on upgrade; it's just too risky to rename a network in an already running deployment, and not worth it just for the sake of branding. I would also argue against the correctness of this flow in the case of a fresh installation; it's probably better to just create the management network originally with a different name (as it probably was until now), as there's no telling what upgrade scripts will be written in the future acting upon network names (such as the vNIC profile scripts), but you can be sure that nobody's gonna remember to update this stored procedure when they're written. Line 1286: END; $procedure$ Line 1287: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/25931 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59e6278f283cafdc2f865e18129349f5905f6d3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
