Alon Bar-Lev has posted comments on this change.

Change subject: packaging: engine-backup: support dwh and reports
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/25850/4/packaging/bin/engine-backup.sh
File packaging/bin/engine-backup.sh:

Line 35:        fi
Line 36: }
Line 37: 
Line 38: get_jasper_db_cred() {
Line 39:        python -c "
> didi: if you add also without using it:
no need to import otopi, just add the small compatibility code from 
otopi::__init__

and make sure the following code is also compatible.

we *NEVER* use print not as function, not sure why it is here.

may be other issues as well, all is solvable with a little will.
Line 40: import ConfigParser
Line 41: import io
Line 42: import os
Line 43: import sys


-- 
To view, visit http://gerrit.ovirt.org/25850
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I188a1823686b211fefb18ceb41e1a80afd9c5de5
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to