Alon Bar-Lev has posted comments on this change.

Change subject: Avoiding legacy health servlet usage
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/26090/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py:

Line 127:             except self._ovirtsdk_api.RequestError as exc:
Line 128:                 self.logger.debug(
Line 129:                     'Error connecting to the Engine API: 
{error}'.format(
Line 130:                         error=str(exc),
Line 131:                     )
should be:

 self.logger.debug(
     'Cannot connect to engine',
     exc_info=True,
 )
Line 132:                 )
Line 133:                 time.sleep(self.ENGINE_DELAY)
Line 134:         if not isUp:
Line 135:             raise RuntimeError(_('Engine unreachable'))


-- 
To view, visit http://gerrit.ovirt.org/26090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to