Sandro Bonazzola has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 4: (1 comment) Minor comment. Please verify http://gerrit.ovirt.org/#/c/26090/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 95: )) Line 96: return isUp Line 97: Line 98: def _waitEngineUp(self): Line 99: self.logger.debug('Waiting for API to check Engine health status') Maybe 'Waiting for response from Engine'? Line 100: Line 101: tries = self.ENGINE_RETRIES Line 102: isUp = False Line 103: sdk = None -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
