Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 4: (3 comments) thanks! some minor notes. http://gerrit.ovirt.org/#/c/26090/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 99: self.logger.debug('Waiting for API to check Engine health status') Line 100: Line 101: tries = self.ENGINE_RETRIES Line 102: isUp = False Line 103: sdk = None not sure you need to initialize this, but not damaging either. Line 104: while not isUp and tries > 0: Line 105: tries -= 1 Line 106: try: Line 107: # Now we are using the SDK to authenticate vs the API Line 123: ], Line 124: insecure=True, Line 125: ) Line 126: isUp = True Line 127: except self._ovirtsdk_api.RequestError: please debug print the exception, as it may indicate something else Line 128: time.sleep(self.ENGINE_DELAY) Line 129: if not isUp: Line 130: raise RuntimeError(_('Engine unreachable')) Line 131: else: Line 127: except self._ovirtsdk_api.RequestError: Line 128: time.sleep(self.ENGINE_DELAY) Line 129: if not isUp: Line 130: raise RuntimeError(_('Engine unreachable')) Line 131: else: no need else post raise exceptional programming pattern is: if failed: raise exception continue as usual Line 132: return sdk Line 133: Line 134: @plugin.event( Line 135: stage=plugin.Stages.STAGE_INIT, -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
