Ayal Baron has posted comments on this change. Change subject: core: Grayed-Out LUNs Support ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java Line 33: VDS vds = DbFacade.getInstance().getVdsDAO().get(getParameters().getVdsId()); How can you read the code like this? the lines are way too long calling the same singletons over and over. You can make it more readable by: dbf = DbFacade.getInstance() vdsId = getParameters().getVdsId() GetDeviceListVDSCommandParameters(getParameters(), vdsId) VDS vds = dbf.getVdsDAO().get(vdsId) -- To view, visit http://gerrit.ovirt.org/4858 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
