Allon Mureinik has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java
Line 27: protected void executeQueryCommand() {
Documenting our discussion with ofrenkel:
move the call to the StoragePoolDAO to here.
Assuming the user has permissions, the storage_pool object should have a
version property, which you can pass to the VDS command instead of having the
VDS command access the database itself.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
Line 180: protected StoragePoolDAO getStoragePoolDAO() {
As we discussed, the version should be received via the parameters, and the
call to the DAO can be removed.
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
