Daniel Erez has posted comments on this change.
Change subject: core: Grayed-Out LUNs Support
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
Line 29: protected void ExecuteVdsBrokerCommand() {
getStoragePoolDAO() isn't available in this command hierarchy,
GetDeviceListVDSCommand doesn't extend AuditLogableBase
(it extends VdcCommandBase). I'll add it to one of the bases..
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
Line 133: public Map<String, Object> getDeviceList(int storageType, Map
options);
Why do I need special generics here?
LUNListReturnForXmlRpc ctr is:
LUNListReturnForXmlRpc(Map<String, Object> innerMap)
--
To view, visit http://gerrit.ovirt.org/4858
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia716e72c6caa097b42d8864ab23144149d360df2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
