Martin Peřina has posted comments on this change. Change subject: tools: remove log4j usage from engine-config ......................................................................
Patch Set 1: Code-Review-1 I really don't like the idea that you remove logging from engine-config completely! Because the same problem can arise with engine-manage-domains, we definitely don't want to remove logging from it. So I see several possible solutions: 1) Check in engine-config.sh if script is executed under root 2) Use sudo in engine-config.sh to execute it under special account with write access to log files (non-root users access to engine-config.sh can be limited using sudoers file) 3) Allow everybody users to write to /var/log/ovirt-engine/notifier Personally, I would prefer 1), if it's really a problem, then 2) -- To view, visit http://gerrit.ovirt.org/26305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
