Martin Peřina has posted comments on this change. Change subject: tools: remove log4j usage from engine-config ......................................................................
Patch Set 1: Also another solution came to my mind: we can change FileAppender to ConsoleAppender only for engine-config and set default level to WARNING. And we can add two command line parameters: --verbose (it will change default level to INFO) and --debug (default level to DEBUG). This was we will have everything logged to console (if needed) and we can remove logging to file. The same we could apply also to engine-manage-domains. I see only one problem for this approach: engine-manage-domains executes engine-config internally, so if we use this solution, we will have to redirect engine-config stdout/stderr to engine-manage-domains stdout/stderr. -- To view, visit http://gerrit.ovirt.org/26305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
