Eli Mesika has posted comments on this change. Change subject: tools: remove log4j usage from engine-config ......................................................................
Patch Set 1: -Verified Adding here a conversation with alonbl via IRC : alonbl> command-line utilities should not write logs unless instructed <alonbl> it should be something like utility --log-level=x --log-file=y .... <alonbl> output to console should be at INFO and above (as we use logger for console as well) <alonbl> default log file is none <alonbl> if you specify log-file=xxx you add file appender with the level of log-level <alonbl> and enjoy all worlds <emesika> OK <emesika> Thanks <alonbl> it should be a change to main() only <alonbl> where you parse the parameters <alonbl> and remove the log4j.xml from /etc <alonbl> or keep it but remove the appender <emesika> OK <alonbl> see: packaging/etc/engine-config/log4j.xml.in <alonbl> all the problems are from this <alonbl> assumption that a utility can write to pre-defined location <alonbl> you should add this appender at runtime only if --log-file was provider <alonbl> you should add this appender at runtime only if --log-file was provided <alonbl> with log level as --log-level or info <alonbl> it must not be RollingFileAppender <alonbl> but plain appender -- To view, visit http://gerrit.ovirt.org/26305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
