Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: do not override answer file when applying post install removal ......................................................................
Patch Set 1: > We should find a way to remove post install variable in generic method. > For permanent solution I recommend to generate post install file with > "OVESETUP/" prefix. > During the init phase, we enumerate OVESETUP/ prefix, look up each variable > by name and set it in environment only if it has post install attribute. And how do you not overwrite answer files? > Any other ideas? 1. http://gerrit.ovirt.org/26043 , which ignores the whole issue and suggests to simply rely on otopi's 'enforced environment' (which iirc we hardly ever used so far in actual usage/doc/etc., never in code, but which does work). If we do go this route, and the only problem is allowing doing that on the command line, we might better make otopi allow that - might be useful in other cases. 2. revert http://gerrit.ovirt.org/26370 and use (some variation of) its patchset 1 - add a new variable to allow configuring nfs on upgrade. -- To view, visit http://gerrit.ovirt.org/26463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
