Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: do not override answer file when applying 
post install removal
......................................................................


Patch Set 1:

I really hope for a simpler solution. Not sure one is possible.

I think this change will "fail" with the following (unlikely?) flow:

 install a machine with no nfs server

 setup 3.3.0 (or so)

 upgrade to 3.3.x with this change applied and with answer file having 
nfsconfigenabled=True

 install nfs service

 upgrade again to a version with this change and without answer file

I think the last stage will ask about nfs config, no?

Please explain the exact function of NFS_CONFIG_ENABLED_LEGACY_IN_POSTINSTALL .

-- 
To view, visit http://gerrit.ovirt.org/26463
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to