Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: do not override answer file when applying post install removal ......................................................................
Patch Set 1: > Something like: OVESETUP_SYSTEM/nfsConfigEnabled -> > OVESETUP_SYSTEM/nfsConfigurationEnabled If we go this route, I'd call it something like 'OVESETUP_SYSTEM/nfsConfigEnabled2' and explain in a comment the reason. Perhaps we should also decide about some convention (prefix or other) regarding these "this was already configured" variables. -- To view, visit http://gerrit.ovirt.org/26463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
