Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: setup: do not override answer file when applying post install removal ......................................................................
packaging: setup: do not override answer file when applying post install removal OVESETUP_SYSTEM/nfsConfigEnabled should be removed from post install file. we need to find a way to do that in generic way, but for time being we provide local solution. the last method we have done to set None at boot stage is good, however the answer file is configuration just like the post install file, we have no way to distinguish. without setting the value at boot stage, the issue would have been resolved at the 2nd setup run, but we want it to be solved at the next setup run. to mark this legacy state a new postinstall variable was added, if it is None then we know that we have legacy post-install and we do not look into the content of OVESETUP_SYSTEM/nfsConfigEnabled. Bug-Url: https://bugzilla.redhat.com/1056777 Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/nfs.py 2 files changed, 43 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Sandro Bonazzola: Looks good to me, approved Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/26463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I907380d1d39c33ffcc43fdd49192a5096a000539 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eyal Edri <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
