Alon Bar-Lev has posted comments on this change. Change subject: aaa: Added mapper usage ......................................................................
Patch Set 8: (4 comments) http://gerrit.ovirt.org/#/c/26970/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 195: mappingConfig.put(Base.ConfigKeys.MODULE, "org.ovirt.engine.extensions.builtin"); Line 196: mappingConfig.put(Base.ConfigKeys.CLASS, Line 197: "org.ovirt.engine.extensions.aaa.builtin.kerberosldap.KerberosLdapMapper"); Line 198: mappingConfig.put("org.ovirt.engine.config.authz.name", domain); Line 199: ExtensionsManager.getInstance().load(mappingConfig); no need now Line 200: Line 201: } Line 202: } Line 203: } http://gerrit.ovirt.org/#/c/26970/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 298: Mapping.InvokeCommands.MAP_USER Line 299: ).mput( Line 300: Mapping.InvokeKeys.USER, Line 301: user), Line 302: true).<String> get(Mapping.InvokeKeys.USER); if it is unsupported, you will not have USER, so you need to add the user as default. Line 303: } Line 304: Line 305: ExtMap outputMap = authnExtension.invoke(new ExtMap().mput( Line 306: Base.InvokeKeys.COMMAND, Line 358: Authn.InvokeKeys.AUTH_RECORD, Line 359: outputMap.<ExtMap> get(Authn.InvokeKeys.AUTH_RECORD) Line 360: ) Line 361: ) Line 362: ); should be optional as well also, I do not understand how you put the entire output into the auth record Line 363: } Line 364: result = outputMap.<ExtMap> get(Authn.InvokeKeys.AUTH_RECORD); Line 365: Line 366: } http://gerrit.ovirt.org/#/c/26970/8/backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java File backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/LdapAuthenticateUserCommand.java: this should be squashed into using new api... has nothing to do with mapper :) Line 1: package org.ovirt.engine.extensions.aaa.builtin.kerberosldap; Line 2: Line 3: Line 4: import org.ovirt.engine.api.extensions.ExtMap; -- To view, visit http://gerrit.ovirt.org/26970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ac853e9011bb6118796a4cd14c0b7425308f3b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
