Alon Bar-Lev has posted comments on this change.

Change subject: aaa: Added mapper usage
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.ovirt.org/#/c/26970/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java:

Line 299:                     ).mput(
Line 300:                             Mapping.InvokeKeys.USER,
Line 301:                             user),
Line 302:                     true).<String> get(Mapping.InvokeKeys.USER);
Line 303:             user = mappedUser != null ? mappedUser : user;
No.... I meant....

 invoke.....get(Mapping.InvokeKeys.USER, user)

:)
Line 304:         }
Line 305: 
Line 306:         ExtMap outputMap = authnExtension.invoke(new ExtMap().mput(
Line 307:                 Base.InvokeKeys.COMMAND,


Line 358:                                         Authn.InvokeKeys.AUTH_RECORD,
Line 359:                                         outputMap.<ExtMap> 
get(Authn.InvokeKeys.AUTH_RECORD)
Line 360:                         )
Line 361:                         , true);
Line 362:                 outputMap = 
mappingResult.containsKey(Authn.InvokeKeys.AUTH_RECORD) ? mappingResult : 
outputMap;
same...

 invoke()....get(Authn.InvokeKeys.AUTH_RECORD, outputMap.<ExtMap> 
get(Authn.InvokeKeys.AUTH_RECORD))
Line 363:             }
Line 364: 
Line 365:             result = outputMap.<ExtMap> 
get(Authn.InvokeKeys.AUTH_RECORD);
Line 366: 


-- 
To view, visit http://gerrit.ovirt.org/26970
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib5ac853e9011bb6118796a4cd14c0b7425308f3b
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to