Yair Zaslavsky has posted comments on this change. Change subject: aaa: Added mapper usage ......................................................................
Patch Set 11: (2 comments) http://gerrit.ovirt.org/#/c/26970/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 173: "org.ovirt.engine.extensions.aaa.builtin.kerberosldap.KerberosLdapAuthn"); Line 174: authConfig.put("ovirt.engine.aaa.authn.profile.name", domain); Line 175: authConfig.put("ovirt.engine.aaa.authn.authz.plugin", domain); Line 176: String mapperName = String.format("builtin-authz-%1$s", domain); Line 177: authConfig.put("ovirt.engine.aaa.authn.mapping.plugin", mapperName); > you do not need these two Done Line 178: authConfig.put("config.change.password.url", blankIfNull(passwordChangeUrlPerDomain.get(domain))); Line 179: authConfig.put("config.change.password.msg", blankIfNull(passwordChangeMsgPerDomain.get(domain))); Line 180: ExtensionsManager.getInstance().load(authConfig); Line 181: http://gerrit.ovirt.org/#/c/26970/11/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/LoginBaseCommand.java: Line 354: Base.InvokeKeys.COMMAND, Line 355: Mapping.InvokeCommands.MAP_AUTH_RECORD Line 356: ).mput( Line 357: Authn.InvokeKeys.AUTH_RECORD, Line 358: outputMap.<ExtMap> get(Authn.InvokeKeys.AUTH_RECORD) > this^ should be result Why? In the usage of the method, I set the result at the authRecord field which is supposed to be already an ExtMap that is the corresponding value of AUTH_RECORD key. Line 359: ) Line 360: , true).<ExtMap> get( Line 361: Authn.InvokeKeys.AUTH_RECORD, Line 362: outputMap.<ExtMap> get(Authn.InvokeKeys.AUTH_RECORD) -- To view, visit http://gerrit.ovirt.org/26970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5ac853e9011bb6118796a4cd14c0b7425308f3b Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
