Moti Asayag has posted comments on this change.
Change subject: core: Run upgradeStoragePool on cluster compatibility change
......................................................................
Patch Set 14: (6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
Line 138: resourceManager.RunVdsCommand(
since UpdateStoragePoolCommand is inherited from CommandBase you should use
CommandBase. runVdsCommand(VDSCommandType commandType, VDSParametersBase
parameters) and remove the use of "VDSBrokerFrontend resourceManager" from this
method.
In addition, wouldn't you care of the return value of this operation ?
Line 146: StorageDomainStaticDAO sdStatDao =
DbFacade.getInstance().getStorageDomainStaticDAO();
you should be able to replace DbFacade.getInstance() with getDbFacadeInstance()
Line 150: log.info("Updating storage domain \"" + domain.getId() +
"\" (type \"" +
please replace log.info() with log.infoFormat() to reduce the amount of
String.class instance creation.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/UpgradeStoragePoolVDSCommandParameters.java
Line 9: @XmlAccessorType(XmlAccessType.NONE)
the @Xml... annotations where added for the sake of wsdl creation used by C#
code.
Those are no longer needed. Please remove both of them.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java
Line 253: StatusOnlyReturnForXmlRpc wrapper = new
StatusOnlyReturnForXmlRpc(xmlRpcReturnValue);
a matter of test - but the return value can be inlined here
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/UpgradeStoragePoolVDSCommand.java
Line 18: log.info("Upgrading storage pool \"" + storagePoolId + "\" to
version \"" + targetVersion + "\"");
please replace log.info with log.infoFormat
--
To view, visit http://gerrit.ovirt.org/2441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I85201624bbb2f8c41cf3b184b89a8e199ff50e99
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
