Omer Frenkel has posted comments on this change. Change subject: core: Run upgradeStoragePool on cluster compatibility change ......................................................................
Patch Set 14: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java Line 115: } please use configuration to have per version values (it will save doing the per-version checks) Line 159: sdStatDao.update(domain); you update here the format of the domains in the db, but when is it updated in the vdsm? what if some domains are inactive? is there a wiki that describe the flow and all you are doing here? -- To view, visit http://gerrit.ovirt.org/2441 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85201624bbb2f8c41cf3b184b89a8e199ff50e99 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
