Alon Bar-Lev has posted comments on this change.

Change subject: core : Allow redirection of all logs to syslog using extension
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/27431/3/backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml
File 
backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml:

Line 10:     <module name="org.apache.commons.collections"/>
Line 11:     <module name="org.apache.commons.configuration"/>
Line 12:     <module name="org.apache.commons.lang"/>
Line 13:     <module name="org.apache.commons.logging"/>
Line 14:     <module name="org.apache.log4j"/>
why do we need all the above? probably we do not use anything but logging?
Line 15:     <module name="org.ovirt.engine.core.extensions-manager"/>
Line 16:     <module name="org.ovirt.engine.api.ovirt-engine-extensions-api"/>
Line 17:   </dependencies>
Line 18: 


-- 
To view, visit http://gerrit.ovirt.org/27431
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to