Alon Bar-Lev has posted comments on this change. Change subject: core : Allow redirection of all logs to syslog using extension ......................................................................
Patch Set 5: (10 comments) http://gerrit.ovirt.org/#/c/27431/5/backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java File backend/manager/modules/extensions-api-root/extensions-api/src/main/java/org/ovirt/engine/api/extensions/logger/Logger.java: Line 3: import org.ovirt.engine.api.extensions.ExtKey; Line 4: import org.ovirt.engine.api.extensions.ExtUUID; Line 5: Line 6: import java.util.logging.LogRecord; Line 7: add java doc? Line 8: public class Logger { Line 9: /** Line 10: * Invoke keys. Line 11: */ http://gerrit.ovirt.org/#/c/27431/5/backend/manager/modules/logger/pom.xml File backend/manager/modules/logger/pom.xml: Line 21: <dependency> Line 22: <groupId>${engine.groupId}</groupId> Line 23: <artifactId>common</artifactId> Line 24: <version>${engine.version}</version> Line 25: </dependency> ? Line 26: Line 27: <dependency> Line 28: <groupId>${engine.groupId}</groupId> Line 29: <artifactId>extensions-manager</artifactId> Line 38: Line 39: <dependency> Line 40: <groupId>org.jboss.spec.javax.servlet</groupId> Line 41: <artifactId>jboss-servlet-api_3.0_spec</artifactId> Line 42: </dependency> ? Line 43: Line 44: <dependency> Line 45: <groupId>commons-lang</groupId> Line 46: <artifactId>commons-lang</artifactId> Line 43: Line 44: <dependency> Line 45: <groupId>commons-lang</groupId> Line 46: <artifactId>commons-lang</artifactId> Line 47: </dependency> ? Line 48: Line 49: </dependencies> Line 50: Line 51: <build> http://gerrit.ovirt.org/#/c/27431/5/backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java File backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java: Line 17: public class LoggerHandler extends Handler { Line 18: Line 19: private final String LOGGER_SERVICE = Logger.class.getName(); Line 20: private long REFRESH_INTERVAL_IN_SECONDS = 60 * 2; Line 21: private ScheduledExecutorService exec; so this should be volatile as well? Line 22: private volatile List<ExtensionProxy> extensions; Line 23: Line 24: @Override Line 25: public void publish(LogRecord record) { Line 26: initRefreshThread(); Line 27: for (ExtensionProxy extension : getExtensions()) { Line 28: extension.invoke(new ExtMap() Line 29: .mput(Base.InvokeKeys.COMMAND, Logger.InvokeCommands.PUBLISH) Line 30: .mput(Logger.InvokeKeys.LOG_RECORD, record)); please ignore errors, add true, true Line 31: } Line 32: } Line 33: Line 34: @Override Line 35: public void flush() { Line 36: for (ExtensionProxy extension : getExtensions()) { Line 37: extension.invoke(new ExtMap() Line 38: .mput(Base.InvokeKeys.COMMAND, Logger.InvokeCommands.FLUSH)); Line 39: } please ignore errors Line 40: } Line 41: Line 42: @Override Line 43: public void close() throws SecurityException { Line 42: @Override Line 43: public void close() throws SecurityException { Line 44: for (ExtensionProxy extension : getExtensions()) { Line 45: extension.invoke(new ExtMap() Line 46: .mput(Base.InvokeKeys.COMMAND, Logger.InvokeCommands.CLOSE)); please ignore errors Line 47: } Line 48: } Line 49: Line 50: public void setRefreshInterval(final long refreshInterval) { Line 47: } Line 48: } Line 49: Line 50: public void setRefreshInterval(final long refreshInterval) { Line 51: REFRESH_INTERVAL_IN_SECONDS = refreshInterval; Do I see you change the constant? Line 52: } Line 53: Line 54: private void initRefreshThread() { Line 55: if (exec == null) { Line 53: Line 54: private void initRefreshThread() { Line 55: if (exec == null) { Line 56: ScheduledExecutorService exec = Executors.newSingleThreadScheduledExecutor(); Line 57: exec.scheduleWithFixedDelay( what stop this thread? Line 58: new Runnable() { Line 59: @Override Line 60: public void run() { Line 61: extensions = null; -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
