Alon Bar-Lev has posted comments on this change. Change subject: core : Allow redirection of all logs to syslog using extension ......................................................................
Patch Set 4: (9 comments) http://gerrit.ovirt.org/#/c/27431/4/backend/manager/modules/logger/pom.xml File backend/manager/modules/logger/pom.xml: Line 21: <dependency> Line 22: <groupId>${engine.groupId}</groupId> Line 23: <artifactId>common</artifactId> Line 24: <version>${engine.version}</version> Line 25: </dependency> Is that required? Line 26: Line 27: <dependency> Line 28: <groupId>${engine.groupId}</groupId> Line 29: <artifactId>extensions-manager</artifactId> Line 38: Line 39: <dependency> Line 40: <groupId>org.jboss.spec.javax.servlet</groupId> Line 41: <artifactId>jboss-servlet-api_3.0_spec</artifactId> Line 42: </dependency> is that required? Line 43: Line 44: <dependency> Line 45: <groupId>commons-lang</groupId> Line 46: <artifactId>commons-lang</artifactId> Line 43: Line 44: <dependency> Line 45: <groupId>commons-lang</groupId> Line 46: <artifactId>commons-lang</artifactId> Line 47: </dependency> not sure this is required Line 48: Line 49: </dependencies> Line 50: Line 51: <build> http://gerrit.ovirt.org/#/c/27431/4/backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java File backend/manager/modules/logger/src/main/java/org/ovirt/engine/core/logger/LoggerHandler.java: Line 16: import java.util.logging.LogRecord; Line 17: Line 18: public class LoggerHandler extends Handler { Line 19: Line 20: private static final String LOGGER_SERVICE = Logger.class.getName(); why have this constant? Line 21: private static final long REFRESH_INTERVAL_IN_SECONDS = 60 * 2; Line 22: private volatile List<ExtensionProxy> extensions; Line 23: Line 24: public LoggerHandler() { Line 17: Line 18: public class LoggerHandler extends Handler { Line 19: Line 20: private static final String LOGGER_SERVICE = Logger.class.getName(); Line 21: private static final long REFRESH_INTERVAL_IN_SECONDS = 60 * 2; please allow override at service.xml Line 22: private volatile List<ExtensionProxy> extensions; Line 23: Line 24: public LoggerHandler() { Line 25: ScheduledExecutorService exec = Executors.newSingleThreadScheduledExecutor(); Line 38: Line 39: @Override Line 40: public void publish(LogRecord record) { Line 41: Iterator<ExtensionProxy> iter = getExtensions().iterator(); Line 42: while (iter.hasNext()) { use for? Line 43: ExtensionProxy extension = iter.next(); Line 44: extension.invoke(new ExtMap() Line 45: .mput(Base.InvokeKeys.COMMAND, Logger.InvokeCommands.PUBLISH) Line 46: .mput(Logger.InvokeKeys.LOG_RECORD, record)); Line 40: public void publish(LogRecord record) { Line 41: Iterator<ExtensionProxy> iter = getExtensions().iterator(); Line 42: while (iter.hasNext()) { Line 43: ExtensionProxy extension = iter.next(); Line 44: extension.invoke(new ExtMap() please ignore errors, see boolean, parameters. Line 45: .mput(Base.InvokeKeys.COMMAND, Logger.InvokeCommands.PUBLISH) Line 46: .mput(Logger.InvokeKeys.LOG_RECORD, record)); Line 47: } Line 48: } Line 48: } Line 49: Line 50: @Override Line 51: public void flush() { Line 52: } add command? Line 53: Line 54: @Override Line 55: public void close() throws SecurityException { Line 56: Iterator<ExtensionProxy> iter = getExtensions().iterator(); http://gerrit.ovirt.org/#/c/27431/4/backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml File backend/manager/modules/logger/src/main/modules/org/ovirt/engine/core/logger/main/module.xml: Line 6: <resource-root path="logger.jar"/> Line 7: </resources> Line 8: Line 9: <dependencies> Line 10: <module name="org.apache.commons.logging"/> not required Line 11: <module name="org.ovirt.engine.core.extensions-manager"/> Line 12: <module name="org.ovirt.engine.api.ovirt-engine-extensions-api"/> Line 13: </dependencies> Line 14: -- To view, visit http://gerrit.ovirt.org/27431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0dae8ffe53c3489af06d6684c72e6b431002404 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
