Allon Mureinik has posted comments on this change.
Change subject: core: Remove obsolete StringUtils class from utils package
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
Like the concept, have some comments on the implementation - see inline.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java
Line 192: private ArrayList<String> split(String str) {
Use org.ovirt.engine.core.compat.StringHelper.isNullOrEmpty(String)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
Line 71: public static ArrayList<Guid> getGuidListFromString(String str) {
org.ovirt.engine.core.compat.StringHelper.isNullOrEmpty(String)
Line 87: ArrayList<Guid> guidList = new ArrayList<Guid>();
Use org.apache.commons.collections.CollectionUtils.isEmpty(Collection) - it
also returns true for nulls
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmOldInfoBuilder.java
Line 115: } catch (UnsupportedEncodingException e) {
Can't we throw something more reasonable?
Also, I'd add a log here.
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
Line 234:
These aren't very readable names.
consider something like KEY_VALUE_SEPARATOR instead of SEPARATOR
--
To view, visit http://gerrit.ovirt.org/5214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib74df28b0bc2c65449eb92c5146fffe4ad8a2e6f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
