Allon Mureinik has posted comments on this change.
Change subject: core: Remove obsolete StringUtils class from utils package
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
Line 74: if (StringHelper.isNullOrEmpty(str)) {
We're trying to kill off the entire compat package - please don't add new
dependencies to it.
You can use common-lang's StringUtils.isEmpty(str)
--
To view, visit http://gerrit.ovirt.org/5214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib74df28b0bc2c65449eb92c5146fffe4ad8a2e6f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
