Ayal Baron has posted comments on this change.
Change subject: core: Remove obsolete StringUtils class from utils package
......................................................................
Patch Set 4: (10 inline comments)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/GuidUtils.java
Line 69: * @param storageIds
what does storage have to do with it? it's just guids
Line 71: * @return - Array of storage <code>Guid</code> type.
same
Line 73: public static ArrayList<Guid> getGuidListFromString(String str) {
why 2 functions?
looks a bit over engineered (unless you already have direct usage of this
function?)
Line 81: * Gets and array of strings of multiple <code>Guid</code> values
, and returns array list of <code>Guid</code>.
s/and/an/
Line 86: * @return - Array of storage <code>Guid</code> type.
again, no relation to storage
Line 90: if (CollectionUtils.isEmpty(strings)) {
isn't this supposed to be "if !"?
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/GuidUtilsTest.java
Line 32: String listValues =
"e61f7070-cd52-46ca-88c2-686e1c70fe44,1eaa381a-fbf9-4ef5-bec2-6e4337f85d66";
just 2?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtils.java
Line 236: private static final String VALUES_SEPARATOR = ",";
this is PAIRS_SEPARATOR
Line 264: map.put(keyval[0], "");
no error handling?
....................................................
File
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/xmlrpc/XmlRpcUtilsTest.java
Line 21: private final String MUL_KEY_VAL = "key1=val1,key2=val2";
2 is not enough
--
To view, visit http://gerrit.ovirt.org/5214
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib74df28b0bc2c65449eb92c5146fffe4ad8a2e6f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
