Michael Pasternak has posted comments on this change. Change subject: core: Do not fail on internal disconnect-at-constructor ......................................................................
Patch Set 1: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/27753/1/src/ovirtsdk/api.py File src/ovirtsdk/api.py: Line 96: if context.manager.has_key(self.__id): Line 97: try: Line 98: self.disconnect() Line 99: except DisconnectedError: Line 100: pass # Or do something else? What? 1. please add optional parameter to disconnect() so it will not throw DisconnectedError (it's faster than caching exception) 2. this change should be added to codegen template only (not to code itself) Line 101: Line 102: # Remove trailing slashes from the URL: Line 103: url = url.rstrip('/') Line 104: -- To view, visit http://gerrit.ovirt.org/27753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
