Yedidyah Bar David has posted comments on this change. Change subject: core: disconnect-at-constructor only if proxy found ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27753/2/src/ovirtsdk/api.py File src/ovirtsdk/api.py: Line 92: Line 93: # Implicitly disconnect and perform cleanup Line 94: # when detected instance of the SDK proxy with Line 95: # ref-count == 0 Line 96: if context.manager.has_key(self.__id) and context.manager[self.__id].get('proxy') is not None: > thanks :) I do not mind doing the copy-and-paste, but I have no time to verify this, never built the sdk nor have I looked at codegen etc. Maintainers - please take over this change. I detailed the actual specific bug this is intended to solve in https://bugzilla.redhat.com/show_bug.cgi?id=996021#c40 . Thanks! Line 97: self.disconnect() Line 98: Line 99: # Remove trailing slashes from the URL: Line 100: url = url.rstrip('/') -- To view, visit http://gerrit.ovirt.org/27753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
