Alon Bar-Lev has posted comments on this change. Change subject: core: disconnect-at-constructor only if proxy found ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/27753/2/src/ovirtsdk/api.py File src/ovirtsdk/api.py: Line 87 Line 88 Line 89 Line 90 Line 91 this ^ should be simply uuid (or random) per bug[1] your last patch[2], or the proper solution to have the cache use weak reference as in bug[1]. releasing anything at constructor instead of freeing resources at closeup is non standard behaviour, until resolved properly we have resource leak and more issues to come, see[1]. [1] https://bugzilla.redhat.com/show_bug.cgi?id=996021 [2] http://gerrit.ovirt.org/#/c/27732/ -- To view, visit http://gerrit.ovirt.org/27753 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14e8e8ca00a99263227053a47129b93bcb27b7d1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
