Simone Tiraboschi has posted comments on this change. Change subject: packaging: setup: Allow separate hosts for dwh/reports ......................................................................
Patch Set 10: Code-Review+1 (1 comment) Looks good to me, but someone else must approve http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/ovirt_engine_setup/engine_common/constants.py File packaging/setup/ovirt_engine_setup/engine_common/constants.py: Line 35: Line 36: Line 37: @util.export Line 38: class FileLocations(object): Line 39: SYSCONFDIR = '/etc' > I just copied it from engine/constants for sysctl. I saw, and I saw that it was there also before my first engine split patch http://gerrit.ovirt.org/#/c/27647/42/packaging/setup/ovirt_engine_setup/constants.py and after that devenv still works so it's not really an issue. It just looks strange to have an absolute path here. I'll investigate after feature freeze; keep it. Line 40: OVIRT_ENGINE_COMMON_DATADIR = config.ENGINE_COMMON_DATADIR Line 41: Line 42: JBOSS_HOME = os.path.join( Line 43: osetupcons.FileLocations.DATADIR, -- To view, visit http://gerrit.ovirt.org/27502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcf1ae9e442d9ab3ab11a8fd68bde4ebc69cdad Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
