Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Allow separate hosts for dwh/reports ......................................................................
Patch Set 10: (1 comment) http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py: Line 161: ) Line 162: Line 163: raise RuntimeError( Line 164: _('Unable to set sysctl kernel.shmmax to minimum requirement') Line 165: ) > as far as I know the shmmax issue is because of how the engine behaves. and This means that if we're not provisioning the DB we need to check the db credentials to in order to verify if specified host is local host. When we added this I asked kernel people if this can cause any harm and they replied that no harm will be done by setting this. Also this is not needed on EL6 where shmmax is already set to arch limit. I see no point in changing the behavior now. Line 166: Line 167: def _get_shmmax(self): Line 168: rc, shmmax, stderr = self.execute( Line 169: ( -- To view, visit http://gerrit.ovirt.org/27502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcf1ae9e442d9ab3ab11a8fd68bde4ebc69cdad Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
