Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Allow separate hosts for dwh/reports ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/config/firewall.py: Line 91: { Line 92: 'name': 'ovirt-jboss-https', Line 93: 'directory': 'ovirt-engine' Line 94: }, Line 95: ]) > I think this should be handled then in the patch adding reports support. it should not go into common now anyway. please move it back. Line 96: Line 97: http://gerrit.ovirt.org/#/c/27502/10/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/system/sysctl.py: Line 161: ) Line 162: Line 163: raise RuntimeError( Line 164: _('Unable to set sysctl kernel.shmmax to minimum requirement') Line 165: ) > This means that if we're not provisioning the DB we need to check the db cr this should be done *ONLY* when provisioning. if manual (local or not) we should not perform any change of postgresql, manual means manual, you can display instructions but not modify system state. again... if you start deferring tasks "no point to"... you will always have partial solutions dragged from version to version. it is shorter to fix than discuss. this is what I've done for you guys so far, and I am sad that this approach is gone now. Line 166: Line 167: def _get_shmmax(self): Line 168: rc, shmmax, stderr = self.execute( Line 169: ( -- To view, visit http://gerrit.ovirt.org/27502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbcf1ae9e442d9ab3ab11a8fd68bde4ebc69cdad Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
