Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: remove PatternFly from source tree ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/29018/1/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 739: Line 740: rm -f "%{engine_data}/branding/ovirt.brand/patternfly" Line 741: rm -f "%{engine_etc}/branding/00-ovirt.brand" Line 742: ln -s /usr/share/patternfly/resources "%{engine_data}/branding/ovirt.brand/patternfly" Line 743: ln -s /usr/share/patternfly/resources "%{engine_etc}/branding/00-ovirt.brand" > why do we need this in Makefile and here? I'm just not familiar with how the Makefile works. Where should the ln go -- Makefile or here? And you're right, I don't need both links. Will fix. Line 744: Line 745: # Line 746: # Register services Line 747: # http://gerrit.ovirt.org/#/c/29018/1/packaging/branding/ovirt.brand/common.css File packaging/branding/ovirt.brand/common.css: Line 1 Line 2 Line 3 > why these cannot be mered into upstream? This is a temporary file that's ovirt-specific and contains UI hacks that are only needed until the entire UI is converted to patternfly. It's not actually patternfly code. Seems I should rename the file, as it's confusing. What would you like me to call it? Line 1: @import url("gwt_common.css"); Line 2: @import url("patternfly/dist/css/patternfly.min.css"); > the resources should not include "dist" directory, it should be the "dist" ok. I can fix. It's take some sed scripting :) some of the stuff assumes a sibling directory called components exist. So I just kept dist and components. See here: https://github.com/patternfly/patternfly If you look in dist/patternfly.css, you'll see it references things in ../components/xxxxx So I can merge, but I'll regexp the ../components/ part out. Line 3: @import url("patternfly-ovirt.css"); Line 4: @import url("patternfly-custom-hacks.css"); Line 5: Line 6: /* LoginPopupView.ui.xml: -- To view, visit http://gerrit.ovirt.org/29018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da6bece78951a98be148050078c6d8201018273 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
