Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: remove PatternFly from source tree ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/29018/3/Makefile File Makefile: Line 28: BUILD_GWT_USERPORTAL=1 Line 29: BUILD_GWT_WEBADMIN=1 Line 30: BUILD_LOCALES=0 Line 31: BUILD_DEV=0 Line 32: PATTERNFLY_DIR=/usr/share/patternfly/resources > this should probably be: Done Line 33: BUILD_UT=1 Line 34: EXTRA_BUILD_FLAGS= Line 35: BUILD_VALIDATION=1 Line 36: BUILD_ENV_VALIDATION=1 Line 447: install -d -m 755 "$(DESTDIR)$(PKG_SYSCONF_DIR)/branding" Line 448: -rm -f "$(DESTDIR)$(PKG_SYSCONF_DIR)/branding/00-ovirt.brand" Line 449: ln -s "$(DATA_DIR)/branding/ovirt.brand" "$(DESTDIR)$(PKG_SYSCONF_DIR)/branding/00-ovirt.brand" Line 450: -rm -f "$(DESTDIR)$(DATA_DIR)/branding/ovirt.brand/patternfly" Line 451: ln -s $(PATTERNFLY_DIR) "$(DESTDIR)$(DATA_DIR)/branding/ovirt.brand/patternfly" > please keep space line here Done Line 452: ln -sf "$(DATA_DIR)/conf/osinfo-defaults.properties" "$(DESTDIR)$(PKG_SYSCONF_DIR)/osinfo.conf.d/00-defaults.properties" Line 453: Line 454: gwt-debug: Line 455: [ -n "$(DEBUG_MODULE)" ] || ( echo "Please specify DEBUG_MODULE" && false ) http://gerrit.ovirt.org/#/c/29018/3/ovirt-engine.spec.in File ovirt-engine.spec.in: Line 219: Requires: openstack-java-keystone-model >= %{openstack_java_version} Line 220: Requires: openstack-java-quantum-client >= %{openstack_java_version} Line 221: Requires: openstack-java-quantum-model >= %{openstack_java_version} Line 222: Requires: openstack-java-resteasy-connector >= %{openstack_java_version} Line 223: Requires: patternfly > and it probably needs to be patternfly1 to allow side-by-side Done Line 224: Requires: postgresql-jdbc Line 225: Requires: quartz Line 226: Requires: snmp4j Line 227: Requires: spring-ldap Line 219: Requires: openstack-java-keystone-model >= %{openstack_java_version} Line 220: Requires: openstack-java-quantum-client >= %{openstack_java_version} Line 221: Requires: openstack-java-quantum-model >= %{openstack_java_version} Line 222: Requires: openstack-java-resteasy-connector >= %{openstack_java_version} Line 223: Requires: patternfly > I think this is backend dependency and is common and not only fedora. Done Line 224: Requires: postgresql-jdbc Line 225: Requires: quartz Line 226: Requires: snmp4j Line 227: Requires: spring-ldap -- To view, visit http://gerrit.ovirt.org/29018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da6bece78951a98be148050078c6d8201018273 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
