Alon Bar-Lev has posted comments on this change. Change subject: userportal, webadmin: remove PatternFly from source tree ......................................................................
Patch Set 4: (2 comments) two more minor comments... http://gerrit.ovirt.org/#/c/29018/4/Makefile File Makefile: Line 448: -rm -f "$(DESTDIR)$(PKG_SYSCONF_DIR)/branding/00-ovirt.brand" Line 449: ln -s "$(DATA_DIR)/branding/ovirt.brand" "$(DESTDIR)$(PKG_SYSCONF_DIR)/branding/00-ovirt.brand" Line 450: Line 451: -rm -f "$(DESTDIR)$(DATA_DIR)/branding/ovirt.brand/patternfly" Line 452: ln -s $(PATTERNFLY_DIR) "$(DESTDIR)$(DATA_DIR)/branding/ovirt.brand/patternfly" oh... sorry... forgot... quote here. Line 453: Line 454: ln -sf "$(DATA_DIR)/conf/osinfo-defaults.properties" "$(DESTDIR)$(PKG_SYSCONF_DIR)/osinfo.conf.d/00-defaults.properties" Line 455: Line 456: gwt-debug: http://gerrit.ovirt.org/#/c/29018/4/README.developer File README.developer: Line 131: directly, as the all-dev sets this. Line 132: Line 133: PATTERNFLY_DIR [/usr/share/patternfly] Line 134: The location of the PatternFly installation. Line 135: please move this after PREFIX so we have all BUILD_ at one block Line 136: BUILD_UT [0] Line 137: Perform unit tests during build. Line 138: Line 139: DEV_BUILD_GWT_DRAFT [0] -- To view, visit http://gerrit.ovirt.org/29018 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1da6bece78951a98be148050078c6d8201018273 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
